Skip to content

feat: vims gv command - #1645

Closed
Woolzie wants to merge 1 commit into
ahrm:developmentfrom
Woolzie:selection
Closed

feat: vims gv command#1645
Woolzie wants to merge 1 commit into
ahrm:developmentfrom
Woolzie:selection

Conversation

@Woolzie

@Woolzie Woolzie commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Command for selecting the previously selected text,
kind of solves #1077 by making reselection easy

(yet to implement the mobile version as of now)

Notes:

  • Does not include changes made by select_next_char or unselect_last_char commands. Is this important? I will have to figure out how to convert AbsoluteRect to AbsoluteDocumentPos then ( idk how to do that ;-; )
  • Should there be a command (default keybinding as gV) that does a combination of select_previous_selection and goto_selected_text?

@ahrm

ahrm commented Jul 18, 2026

Copy link
Copy Markdown
Owner

Added a simpler implementation in e9bf323. Now when we execute the existing goto_selected_text command, we also re-select the text if it is unselected.

@ahrm ahrm closed this Jul 18, 2026
@Woolzie

Woolzie commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

@ahrm e9bf323 accidental single clicks on a character will set the selection on that character. My implementation was a little complicated to avoid that.

Also, I cleaned up my commit so that it doesnt try to do too much at once. I hope you can have another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants